Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add diagram to reference #3906

Merged

Conversation

gonmmarques
Copy link
Contributor

@gonmmarques gonmmarques commented Oct 12, 2024

Relates to kubeflow/katib#2442

I was a bit unsure on how the doc should look like and if this is correct, please let me know if I missed something.

Copy link

Hi @gonmmarques. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gonmmarques gonmmarques changed the title Docs/add diagram to reference docs: add diagram to reference Oct 12, 2024
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @gonmmarques!
Please fix the CI checks.

gonmmarques and others added 3 commits October 14, 2024 14:25
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
@gonmmarques
Copy link
Contributor Author

Thank you for doing this @gonmmarques! Please fix the CI checks.

@andreyvelich Thank you for the review and the heads-up :) Let me know if I missed something else.

In the spirit of Hacktoberfest, and if this PR is accepted, please consider adding the label "hacktoberfest-accepted”. Thanks.

Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
gonmmarques and others added 3 commits October 15, 2024 14:18
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @gonmmarques!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3c7d3de into kubeflow:master Oct 15, 2024
6 checks passed
@gonmmarques
Copy link
Contributor Author

gonmmarques commented Oct 15, 2024

Thanks for the updates @gonmmarques! /lgtm /approve

@andreyvelich You are welcome and sorry for missing some of the review comments. Can you correct the label to hacktoberfest-accepted?

@gonmmarques gonmmarques deleted the docs/add-diagram-to-reference branch October 15, 2024 15:14
@andreyvelich
Copy link
Member

@gonmmarques We don't have such label in the website, and I don't think we participate in hacktoberfest this year, isn't ?

@gonmmarques
Copy link
Contributor Author

Hacktoberfest is indeed opt-in for maintainers. To participate, either the repository needs to have the hacktoberfest topic or the PR needs to have the hacktoberfest-accepted .

Since I saw you added the label hacktoberfest on the PR I thought you were wanting to accept into the hacktoberfest.

Thanks anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants