Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training: Update example to run PyTorchJob with torchrun #3896

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

andreyvelich
Copy link
Member

I updated PyTorchJob getting started example to make it run with `torchrun.

/assign @kubeflow/wg-training-leads @kuizhiqing
/hold until this merged kubeflow/training-operator#2276

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Oct 9, 2024
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

We can unblock it, since this PR has been merged: kubeflow/training-operator#2276
/hold cancel

@google-oss-prow google-oss-prow bot merged commit aae74a5 into kubeflow:master Oct 21, 2024
6 checks passed
@andreyvelich andreyvelich deleted the training-update-example branch October 21, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants