-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model registry: update MLOps diagrams #3828
model registry: update MLOps diagrams #3828
Conversation
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
I liked the diagram @tarilabs ! /lgtm |
/hold for review |
@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation |
thanks! I'm starting to followup on received feedback which I didn't have bandwidth to act upon before. It is a valid comment, even tho I'd say for the most past some components mainly push and occasionally pull (or viceversa) but I concur a bidirectional symmetric arrow might just be good enough, will do 👍 |
Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@StefanoFioravanzo with 8b3b40e revised as follows:
I've left the other arrows unchanged, since in those automated components I would expect the components to index/catalog the result into the Model Registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @tarilabs, looks great!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, ederign, rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All comments in this PR looks addressed to me, /remove-hold |
Based on previous feedback from:
Reorganize diagrams as follows:
2.a. use similar style from https://www.kubeflow.org/docs/components/training/overview/#why-training-operator- and adapt to highlight the Model Registry box
Quick demo:
This actualize the agreement from:
@StefanoFioravanzo @andreyvelich wdyt ?