Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model registry: update MLOps diagrams #3828

Conversation

tarilabs
Copy link
Member

Based on previous feedback from:

Reorganize diagrams as follows:

  1. make MLOps inner Vs outer cycle smaller just to introduce the concept
  2. re-use overall architecture diagram for Kubeflow introduced with Implement a Reusable E2E Kubeflow ML Lifecycle #3728
    2.a. use similar style from https://www.kubeflow.org/docs/components/training/overview/#why-training-operator- and adapt to highlight the Model Registry box

Quick demo:
Screenshot 2024-07-26 at 10 44 24

This actualize the agreement from:

@StefanoFioravanzo @andreyvelich wdyt ?

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@ederign
Copy link
Member

ederign commented Jul 26, 2024

I liked the diagram @tarilabs ! /lgtm

@tarilabs
Copy link
Member Author

/hold for review

@StefanoFioravanzo
Copy link
Member

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

@tarilabs
Copy link
Member Author

@tarilabs Nice diagram! All the components that "push" metadata to the model registry can also "pull" from it. How can we better represent this symmetry? Directional rows may give a wrong representation

thanks! I'm starting to followup on received feedback which I didn't have bandwidth to act upon before.

It is a valid comment, even tho I'd say for the most past some components mainly push and occasionally pull (or viceversa) but I concur a bidirectional symmetric arrow might just be good enough, will do 👍

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs
Copy link
Member Author

@StefanoFioravanzo with 8b3b40e revised as follows:

  • "Model Development" bidirectional: I can totally see the interactivity in both directions, especially during "inner loops" iterations
  • "Model Serving" the direction was mean to flow from Model Registry, to KServe

I've left the other arrows unchanged, since in those automated components I would expect the components to index/catalog the result into the Model Registry

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @tarilabs, looks great!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, ederign, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member Author

tarilabs commented Aug 7, 2024

All comments in this PR looks addressed to me,
and socialized this PR with all the folks who had original comments (links in first message) that this PR is meant to follow-up on--as agreed.

/remove-hold

@google-oss-prow google-oss-prow bot merged commit 482a3c3 into kubeflow:master Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants