Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib: Add KATIB_POSTGRESQL_SSL_MODE variable of Katib DB Manager #3696

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ckcd
Copy link
Contributor

@ckcd ckcd commented Mar 6, 2024

This follow-up PR reflects a change from kubeflow/katib#2266, which introduced a new environment variable option to allow users to specify the value of Postgres sslmode.

It updates Katib DB Manager part of Environment Variables for Katib Components.

Copy link

Hi @ckcd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Kun Chang <curtis@mail.ustc.edu.cn>
@ckcd
Copy link
Contributor Author

ckcd commented Mar 6, 2024

@andreyvelich PTAL, thanks a lot.

@ckcd
Copy link
Contributor Author

ckcd commented Mar 6, 2024

/assign @andreyvelich

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @ckcd!
/ok-to-test
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, ckcd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 06592b8 into kubeflow:master Mar 6, 2024
7 checks passed
@ckcd
Copy link
Contributor Author

ckcd commented Mar 7, 2024

@andreyvelich Thanks for your approval !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants