Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated banner for Katib docs #2088

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

andreyvelich
Copy link
Member

All Katib docs should be up to date for 1.1 release from 11th of June, see this: kubeflow/katib#1211.

/cc @gaocegege @johnugeorge @jlewi

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jlewi
Copy link
Contributor

jlewi commented Aug 7, 2020

@andreyvelich @gaocegege Looks like you guys need an OWNERs file so you can approve your changes.

@andreyvelich
Copy link
Member Author

@jlewi We have already created OWNERS file for hyperparameter-tuning section: https://github.com/kubeflow/website/blob/master/content/en/docs/components/hyperparameter-tuning/OWNERS.
This PR also makes changes for reference.
I created PR to add OWNERS file there: #2092

@andreyvelich
Copy link
Member Author

@gaocegege @johnugeorge We need to get lgtm on this PR again.

Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5f29767 into kubeflow:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants