Document alternative deploy method of Kubeflow Pipelines #1174
Conversation
|
This is part of kubeflow/pipelines#1638 |
|
/lgtm |
|
/assign @IronPan |
…nd where the manifest is
|
/assign |
|
Hi @sarahmaddox, thanks a lot for the detailed review! It's really helpful to me because I'm not a native speaker of English. I'm currently on vacation, will follow up with fixes after Oct. 7 |
|
/lgtm Thanks @Bobgy! This doc LGTM. I've added a hold, to give @IronPan and @jingzhang36 the opportunity to review the page too. |
|
@sarahmaddox thanks for the detailed review and approval! @jingzhang36 has already LGTMed. I'm waiting for the team to decide on a consistent branding. |
|
@IronPan reminder, do you want to review this? Especially, can you take a look at this one #1174 (comment)? |
|
/hold cancel |
|
|
||
| 1. Deploy latest version of Kubeflow Pipelines: | ||
| ``` | ||
| export PIPELINE_VERSION={{% kfp-latest-version %}} |
There was a problem hiding this comment.
who will be maintaining kfp-latest-version?
alternatively we could publish the file to gs://ml-pipeline/pipeline-lite/latest/namespaced-install.yaml
and refer from there.
wdyt?
There was a problem hiding this comment.
I think it's important we make the version explicit, it affects what command they use to delete it.
What do you think about adding an extra step to our release book?
There was a problem hiding this comment.
+1 to making the version explicit, and to adding the step to the release book. (Doc updates should be part of each release, and part of each feature-development task.)
There was a problem hiding this comment.
discussed, I will add this to release book
|
Hi @sarahmaddox @IronPan, thanks for the suggestions. I've updated the doc:
|
|
Thanks for these changes @Bobgy! There are just a few formatting things to fix up before we can publish the doc. Once it's published, we can iterate on a bit more polishing. It'll be good to get this doc out there for people to use. |
|
Thanks for the review @sarahmaddox! I've made suggested changes. Please take a brief review again. |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) * initial * Document alternative deploy method of Kubeflow Pipelines * adjust wording * Adjust wording to give more context of choices user have * Change kubectl apply -k to use github url, make it easier to understand where the manifest is * Improvements based on Sarah's review * Update KFP lite branding to KFP standalone * Update to make the doc GCP specific * Update gcp create cluster guide * Rename deployment-alternatives doc to standalone deployment gcp * Address review comments * Update standalone-deployment-gcp.md
) * initial * Document alternative deploy method of Kubeflow Pipelines * adjust wording * Adjust wording to give more context of choices user have * Change kubectl apply -k to use github url, make it easier to understand where the manifest is * Improvements based on Sarah's review * Update KFP lite branding to KFP standalone * Update to make the doc GCP specific * Update gcp create cluster guide * Rename deployment-alternatives doc to standalone deployment gcp * Address review comments * Update standalone-deployment-gcp.md
) * initial * Document alternative deploy method of Kubeflow Pipelines * adjust wording * Adjust wording to give more context of choices user have * Change kubectl apply -k to use github url, make it easier to understand where the manifest is * Improvements based on Sarah's review * Update KFP lite branding to KFP standalone * Update to make the doc GCP specific * Update gcp create cluster guide * Rename deployment-alternatives doc to standalone deployment gcp * Address review comments * Update standalone-deployment-gcp.md
) * initial * Document alternative deploy method of Kubeflow Pipelines * adjust wording * Adjust wording to give more context of choices user have * Change kubectl apply -k to use github url, make it easier to understand where the manifest is * Improvements based on Sarah's review * Update KFP lite branding to KFP standalone * Update to make the doc GCP specific * Update gcp create cluster guide * Rename deployment-alternatives doc to standalone deployment gcp * Address review comments * Update standalone-deployment-gcp.md
@jessiezcc @IronPan can you help me review/find someone to help me review this?
The new page can be found at https://deploy-preview-1174--competent-brattain-de2d6d.netlify.com/docs/pipelines/deployment-alternatives/
This change is