Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kfctl-k8s-istio.md #1044

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Update kfctl-k8s-istio.md #1044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8626700
Update kfctl-k8s-istio.md
swiftdiaries Aug 7, 2019
f940752
Keep both versions for install instructions
swiftdiaries Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions content/docs/started/k8s/kfctl-k8s-istio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,17 @@ This config creates a vanilla deployment of Kubeflow with all its core component

Follow these steps to deploy Kubeflow:

1. Download a `kfctl` release from the [Kubeflow releases page](https://github.com/kubeflow/kubeflow/releases/) and unpack it:
1. Download the latest `kfctl` release from the [Kubeflow releases page](https://github.com/kubeflow/kubeflow/releases/) and unpack it:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! I'd like to give people the option of doing the download and unpack manually if they prefer.

Suggestion: Leave the original instructions in place but offer your option to do the download and unpack in just 2 commands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review Sarah!
Sorry for the late reply

Copy link
Member Author

@swiftdiaries swiftdiaries Aug 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tar -xvf kfctl_<release tag>_<platform>.tar.gz
opsys=linux # darwin for Mac

curl -s https://api.github.com/repos/kubeflow/kubeflow/releases/latest |\
grep browser_download |\
grep $opsys |\
cut -d '"' -f 4 |\
xargs curl -O -L && \
tar -zvxf kfctl_*_${opsys}.tar.gz
```

1. Run the following commands to set up and deploy Kubeflow. The code below includes an optional command to add the binary `kfctl` to your path. If you don't add the binary to your path, you must use the full path to the `kfctl` binary each time you run it.
Expand Down