Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated pipelines SDK guide #795

Closed
sarahmaddox opened this issue Jun 12, 2019 · 6 comments
Closed

Outdated pipelines SDK guide #795

sarahmaddox opened this issue Jun 12, 2019 · 6 comments

Comments

@sarahmaddox
Copy link
Contributor

The guide to creating a pipeline component instructs people to create a class that inherits from dsl.ContainerOp - class TrainerOp(dsl.ContainerOp)
https://www.kubeflow.org/docs/pipelines/sdk/build-component/#create-a-python-class-for-your-component

But the related sample has since been updated to use a function that returns a ContainerOp:
https://github.com/kubeflow/pipelines/blob/master/samples/xgboost-spark/xgboost-training-cm.py#L124

We should update the doc to match the sample.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.70. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sarahmaddox sarahmaddox added doc-sprint Issues to work on during the Kubeflow Doc Sprint kind/bug and removed kind/feature labels Jun 27, 2019
@OfficePop
Copy link
Contributor

I'd like to contribute on this article next, @sarahmaddox if you could assign when you have a chance. Thanks!

@sarahmaddox
Copy link
Contributor Author

Thanks @OfficePop

/assign @OfficePop

@OfficePop
Copy link
Contributor

PR 971 created for this issue.

@sarahmaddox
Copy link
Contributor Author

Congrats and thanks @OfficePop!

/close

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox: Closing this issue.

In response to this:

Congrats and thanks @OfficePop!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bermudezmt added a commit to bermudezmt/website that referenced this issue Nov 14, 2019
@sarahmaddox sarahmaddox added doc-sprint-2019-07 and removed doc-sprint Issues to work on during the Kubeflow Doc Sprint labels Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants