-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth client instructions are ambiguous #376
Comments
From @kunmingg on December 21, 2018 23:6 docs located at: https://github.com/kubeflow/website/blob/master/content/docs/started/getting-started-gke.md |
+1 that it's confusing. The "Name" in the UI is an arbitrary name that the user gives to this particular OAuth client ID. I'll clarify that in the docs. /assign |
Thanks @sarahmaddox is this fixed by #377? |
Yes it is. I don't know why the "fixed" annotation on the PR didn't work. |
@sarahmaddox: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From @vfontama on December 21, 2018 21:21
The instructions to create credentials is a bit ambiguous. Specifically, in step 2 where we set the "Authorized redirect URIs" the instructions have this sample: "https://.endpoints..cloud.goog/_gcp_gatekeeper/authenticate".
The is straightforward. However, the is confusing. It is not clear which name to use: In the screenshot the "Name" field has a different name from the name used in the "Authorized redirect URIs" field. So it's not clear if we should use the same name or not.
Copied from original issue: kubeflow/pipelines#586
The text was updated successfully, but these errors were encountered: