Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth client instructions are ambiguous #376

Closed
sarahmaddox opened this issue Dec 22, 2018 · 7 comments
Closed

OAuth client instructions are ambiguous #376

sarahmaddox opened this issue Dec 22, 2018 · 7 comments
Assignees

Comments

@sarahmaddox
Copy link
Contributor

From @vfontama on December 21, 2018 21:21

The instructions to create credentials is a bit ambiguous. Specifically, in step 2 where we set the "Authorized redirect URIs" the instructions have this sample: "https://.endpoints..cloud.goog/_gcp_gatekeeper/authenticate".

The is straightforward. However, the is confusing. It is not clear which name to use: In the screenshot the "Name" field has a different name from the name used in the "Authorized redirect URIs" field. So it's not clear if we should use the same name or not.

screen shot 2018-12-21 at 12 21 45 pm

Copied from original issue: kubeflow/pipelines#586

@sarahmaddox
Copy link
Contributor Author

From @yebrahim on December 21, 2018 21:23

/assign @jlewi
/assign @kunmingg
I thought this can be clearer as well, any thoughts guys?

@sarahmaddox
Copy link
Contributor Author

@sarahmaddox
Copy link
Contributor Author

+1 that it's confusing. The "Name" in the UI is an arbitrary name that the user gives to this particular OAuth client ID. I'll clarify that in the docs.

/assign

@sarahmaddox
Copy link
Contributor Author

/unassign @jlewi jlewi
/unassign @kunmingg

@jlewi
Copy link
Contributor

jlewi commented Dec 26, 2018

Thanks @sarahmaddox is this fixed by #377?

@jlewi jlewi changed the title OAth client instructions are ambiguous OAuth client instructions are ambiguous Dec 26, 2018
@sarahmaddox
Copy link
Contributor Author

Yes it is. I don't know why the "fixed" annotation on the PR didn't work.
/close

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox: Closing this issue.

In response to this:

Yes it is. I don't know why the "fixed" annotation on the PR didn't work.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants