Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube instructions for 0.6 shouldn't use kfctl.sh #1023

Closed
jlewi opened this issue Aug 5, 2019 · 6 comments
Closed

minikube instructions for 0.6 shouldn't use kfctl.sh #1023

jlewi opened this issue Aug 5, 2019 · 6 comments
Assignees
Labels
help wanted Extra attention is needed kind/bug platform/minikube priority/p0 release/v0.6 Doc updates reqd before we can archive the v0.6 doc branch

Comments

@jlewi
Copy link
Contributor

jlewi commented Aug 5, 2019

The minikube instructions need to be updated
https://www.kubeflow.org/docs/started/getting-started-minikube/

We should no longer tell users to use kfctl.sh; that script will no longer work since its using ksonnet.

Instead the instructions should be

  1. Setup minikube
  2. Follow the instructions for installing Kubeflow on an existing cluster

For the latter we can probably just link to the appropriate section
https://www.kubeflow.org/docs/started/getting-started-k8s/

Note the latter section is being revised in #977

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sarahmaddox sarahmaddox added the release/v0.6 Doc updates reqd before we can archive the v0.6 doc branch label Aug 6, 2019
@jlewi
Copy link
Contributor Author

jlewi commented Aug 12, 2019

The instructions were partially updated in #1051
https://www.kubeflow.org/docs/reference/virtual-dev/getting-started-minikube/

The instructions now point users at installing on existing kubernetes clusters but the link is broken

The port-forwarding command also looks incorrect.

Users need to port-forward to the ISTIO gateway not to the Ambassador service.

@abhi-g Are you working on updating the minikube instructions?

/cc @carmine

@abhi-g
Copy link
Member

abhi-g commented Aug 12, 2019 via email

@sarahmaddox
Copy link
Contributor

PR #1067 fixed the port forwarding instructions.

@abhi-g How's it going with the script?

@sarahmaddox
Copy link
Contributor

/assign @abhi-g

@jlewi
Copy link
Contributor Author

jlewi commented Sep 8, 2019

The instructions
https://www.kubeflow.org/docs/other-guides/virtual-dev/getting-started-minikube/

No longer reference kfctl.sh. The instructions have been updated to tell people to use kfctl.

So this has been fixed.

@jlewi jlewi closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/bug platform/minikube priority/p0 release/v0.6 Doc updates reqd before we can archive the v0.6 doc branch
Projects
None yet
Development

No branches or pull requests

3 participants