Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Deepspeed demo dependencies #2294

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

Syulin7
Copy link
Contributor

@Syulin7 Syulin7 commented Oct 20, 2024

What this PR does / why we need it:
Upgrade deepspeed demo dependencies and remove unused dependencies.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2287 #2288

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7
Copy link
Contributor Author

Syulin7 commented Oct 20, 2024

cc @andreyvelich @tenzen-y

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11426360935

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11412887414: 0.0%
Covered Lines: 73
Relevant Lines: 73

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 81d02bf into kubeflow:master Oct 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants