Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for HuggingFace Dataset Provider #2085

Merged

Conversation

andreyvelich
Copy link
Member

In this PR: #2075, I also change this:
HfDatasetParams -> HuggingFaceDatasetParams.

We need to fix it in our example.
Also, I fix the S3 dataset provider import.

/assign @kubeflow/wg-training-leads @deepanker13

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8854002186

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix-train-example-import at 35.431%

Totals Coverage Status
Change from base Build 8853861303: 35.4%
Covered Lines: 4380
Relevant Lines: 12362

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 26, 2024
@google-oss-prow google-oss-prow bot merged commit f8f7363 into kubeflow:master Apr 26, 2024
38 checks passed
@andreyvelich andreyvelich deleted the fix-train-example-import branch April 26, 2024 21:29
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants