Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webhook validations for the XGBoostJob #2052

Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I implemented webhook validations for the XGBoostJob.
Additionally, I didn't add any additional validations. The traininig-operator has the same validations the same as before.

Although we potentially commonize podTemplate validations, I leave such commonize in the follow-ups.

This PR depends on #2035

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1993

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/hold
for review

@coveralls
Copy link

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 8637552831

Details

  • 49 of 74 (66.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on implement-xgboost-webhook-validation at 35.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhooks/xgboost/xgboostjob_webhook.go 49 74 66.22%
Totals Coverage Status
Change from base Build 8637479311: 35.2%
Covered Lines: 4350
Relevant Lines: 12354

💛 - Coveralls

@tenzen-y tenzen-y force-pushed the implement-xgboost-webhook-validation branch 2 times, most recently from 850ff3a to d981e7e Compare April 10, 2024 20:39
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the implement-xgboost-webhook-validation branch from d981e7e to ffe30ca Compare April 10, 2024 20:40
@tenzen-y
Copy link
Member Author

These are the third webhook validations. PTAL.
/assign @andreyvelich @johnugeorge

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
/lgtm
/assign @johnugeorge

@google-oss-prow google-oss-prow bot added the lgtm label Apr 10, 2024
@johnugeorge
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 824814c into kubeflow:master Apr 11, 2024
38 checks passed
@tenzen-y tenzen-y deleted the implement-xgboost-webhook-validation branch April 11, 2024 05:12
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants