Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train api dataset download changes #1959

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Train api dataset download changes #1959

merged 8 commits into from
Dec 14, 2023

Conversation

deepanker13
Copy link
Contributor

What this PR does / why we need it:

  1. Adding dataset download support in the init container image from s3 based object stores.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
partially Fixes #1945

Checklist:

  • Docs included if any changes are user facing

@deepanker13
Copy link
Contributor Author

deepanker13 commented Dec 7, 2023 •
edited
Loading

@johnugeorge @andreyvelich @tenzen-y @kuizhiqing please have a look if the code structure looks fine or not

@coveralls
Copy link

coveralls commented Dec 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7194267408

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.883%
Totals Coverage Status
Change from base Build 7182544719: 0.0%
Covered Lines: 3754
Relevant Lines: 8754
💛 - Coveralls

@deepanker13
Copy link
Contributor Author

/hold dependent on #1954 and #1958

@deepanker13 deepanker13 mentioned this pull request Dec 11, 2023
Merged
1 task
@deepanker13 deepanker13 force-pushed the train_api_dataset branch 4 times, most recently from 0fe0b1e to bde2473 Compare December 11, 2023 11:44
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Dec 13, 2023
@deepanker13
Copy link
Contributor Author

/hold cancel

@deepanker13
Copy link
Contributor Author

deepanker13 commented Dec 13, 2023 •
edited
Loading

@johnugeorge I have rebased the branch

@deepanker13
Copy link
Contributor Author

@johnugeorge can we merge this?

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 14, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepanker13, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1400f1f into kubeflow:master Dec 14, 2023
33 checks passed
@rimolive rimolive mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepanker13 @coveralls @johnugeorge