Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement integration test for TFJob related to suspend semantics #1867

Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I implemented integration test for TFJob related to suspend semantics.

follow-up: #1859

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5623771772

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 39.818%

Totals Coverage Status
Change from base Build 5623533920: 0.02%
Covered Lines: 3891
Relevant Lines: 9772

💛 - Coveralls

@tenzen-y
Copy link
Member Author

@terrytangyuan Thanks for the quick review :) Could you restart unrelated failed CI?

https://github.com/kubeflow/training-operator/actions/runs/5623771809/job/15239180851?pr=1867

@google-oss-prow google-oss-prow bot merged commit 42d10b7 into kubeflow:master Jul 21, 2023
24 checks passed
@tenzen-y tenzen-y deleted the implement-suspend-test-for-tfjob branch July 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants