Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself to reviewer. #1689

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

kuizhiqing
Copy link
Member

@kuizhiqing kuizhiqing commented Nov 8, 2022

Add myself to reviewer.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Add myself to reviewer.
@coveralls
Copy link

coveralls commented Nov 8, 2022

Pull Request Test Coverage Report for Build 3416701831

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 39.485%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 7 77.2%
Totals Coverage Status
Change from base Build 3413733833: -0.04%
Covered Lines: 2683
Relevant Lines: 6795

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @kuizhiqing for all contributions on paddlepaddle.

/lgtm
/approve

@johnugeorge
Copy link
Member

Ref: kubeflow/internal-acls#583

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @kuizhiqing!
/verify-owners

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, johnugeorge, kuizhiqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/verify-owners

1 similar comment
@kuizhiqing
Copy link
Member Author

/verify-owners

@google-oss-prow google-oss-prow bot merged commit dd77069 into kubeflow:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants