Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CD using GitHub Actions #1196

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

gaocegege
Copy link
Member

Signed-off-by: cegao cegao@tencent.com

Signed-off-by: cegao <cegao@tencent.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.719% when pulling 0ad7bca on gaocegege:cd into 6c58dcb on kubeflow:master.

@andreyvelich
Copy link
Member

As I can see for the TF Operator GitHub actions have not been triggered also.
Similar problem, as here: kubeflow/katib#1407.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions will be triggered once we merge this to master I believe (at least how it worked for MPI Operator).

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a0b309e into kubeflow:master Dec 22, 2020
@terrytangyuan
Copy link
Member

Actually it's already being triggered: https://github.com/kubeflow/tf-operator/actions

@gaocegege
Copy link
Member Author

Got it. Maybe we should remove the existing workflow. It always fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants