fix: minor changes

* add Dockerfile context to github workflow yaml * add commenets to the head of Dockerfile
kubeflow · Mar 30, 2024 · fbcb75b · fbcb75b
1 parent 9e1d6c5
commit fbcb75b
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 0 deletions.
diff --git a/.github/workflows/publish-example-images.yaml b/.github/workflows/publish-example-images.yaml
@@ -57,5 +57,7 @@ jobs:
             context: examples/mxnet/tune
           - component-name: pytorch-dist-mnist
             dockerfile: examples/pytorch/mnist/Dockerfile
+            context: examples/pytorch/mnist
           - component-name: pytorch-dist-mnist-mpi
             dockerfile: examples/pytorch/mnist/Dockerfile-mpi
+            context: examples/pytorch/mnist
diff --git a/examples/pytorch/elastic/imagenet/Dockerfile b/examples/pytorch/elastic/imagenet/Dockerfile
@@ -1,3 +1,6 @@
+# We need to use the nvcr.io/nvidia/pytorch image as a base image to support both linux/amd64 and linux_arm64 platforms.
+# PyTorch=2.2.0, cuda=12.3.2
+# Ref: https://docs.nvidia.com/deeplearning/frameworks/pytorch-release-notes/rel-24-01.html#rel-24-01
 ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:24.01-py3
 FROM $BASE_IMAGE
 

diff --git a/examples/pytorch/mnist/Dockerfile b/examples/pytorch/mnist/Dockerfile
@@ -1,3 +1,6 @@
+# We need to use the nvcr.io/nvidia/pytorch image as a base image to support both linux/amd64 and linux_arm64 platforms.
+# PyTorch=2.2.0, cuda=12.3.2
+# Ref: https://docs.nvidia.com/deeplearning/frameworks/pytorch-release-notes/rel-24-01.html#rel-24-01
 FROM nvcr.io/nvidia/pytorch:24.01-py3
 
 RUN pip install tensorboardX==2.6.2

diff --git a/examples/pytorch/mnist/Dockerfile-mpi b/examples/pytorch/mnist/Dockerfile-mpi
@@ -1,3 +1,6 @@
+# We need to use the nvcr.io/nvidia/pytorch image as a base image to support both linux/amd64 and linux_arm64 platforms.
+# PyTorch=2.2.0, cuda=12.3.2
+# Ref: https://docs.nvidia.com/deeplearning/frameworks/pytorch-release-notes/rel-24-01.html#rel-24-01
 FROM nvcr.io/nvidia/pytorch:24.01-py3
 
 RUN pip install tensorboardX==2.6.2

diff --git a/examples/pytorch/smoke-dist/Dockerfile b/examples/pytorch/smoke-dist/Dockerfile
@@ -1,3 +1,6 @@
+# We need to use the nvcr.io/nvidia/pytorch image as a base image to support both linux/amd64 and linux_arm64 platforms.
+# PyTorch=2.2.0, cuda=12.3.2
+# Ref: https://docs.nvidia.com/deeplearning/frameworks/pytorch-release-notes/rel-24-01.html#rel-24-01
 FROM nvcr.io/nvidia/pytorch:24.01-py3
 
 RUN mkdir -p /opt/mlkube