Add reusable scripts to kubeflow/testing #817
Conversation
|
This is great! @Jeffwan /lgtm |
scripts/update-changelog.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| github_changelog_generator -t ${GITHUB_TOKEN} -u kubeflow -p kubeflow \ |
There was a problem hiding this comment.
Is there any repo still using this?
KFP was using this tool, but once the repo size grow to a certain limit, it always fail on github rate limit.
If we do not find existing users, I'd suggest getting rid of it.
There was a problem hiding this comment.
I don't know any users on this now.
For 1.2 release on kuebflow/kfctl/manifest. I use a different log generator scripts and manually categorize PRs.
I am fine to remove it. What do you use in KFP now? If there's a recommended way, we should remove it since it will encounter rate limit issue
This scripts will encounter rate limit issue in large repo. We should find better ways to generate changlog
|
Update: Remove github_changelog_generator as per Bobgy's suggestion. If there's better ways to handle large repo, we will add the scripts here later |
|
You may find my investigations in kubeflow/pipelines#3920. KFP now uses a subset of https://www.conventionalcommits.org/en/v1.0.0/ conventions to generate the changelog. and the PR that automates & documents it with KFP: kubeflow/pipelines#4033 |
|
Thanks for the update! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move some helpful scripts to kubeflow/testing.
See kubeflow/kubeflow#5419 for more details