Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile for testing image #65

Merged
merged 3 commits into from
Mar 15, 2018
Merged

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 15, 2018

#64 failed to update one line

@lluunn
Copy link
Contributor Author

lluunn commented Mar 15, 2018

/cc @ankushagarwal

@ankushagarwal
Copy link

The tests are failing because - by upgrading the ksonnet version, it's API has changed. We need to run ks upgrade on every existing ksonnet application.

@ankushagarwal
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 15, 2018
@ankushagarwal
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79c5f16 into kubeflow:master Mar 15, 2018
jimexist pushed a commit to jimexist/testing that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants