Define a v0.8 release #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran the job Here's a created PR: The created PR is incorrect; it is trying to merge it into master. |
* Update applications.yaml with a v0.8 release. * The purpose of this PR is to check that just by defining the appropriate release we can begin building images from release branches and updating the release branch of kubeflow/manifests * Related to kubeflow#450 - Continuous delivery of Kubeflow applications * Create a python script for opening up the PR; this script replaces the bash script rebuild-manifests.sh that was used previously * The new script doesn't assume that the base branch for PRs is master. We need this to support updating release branches. * Create a profile in skaffold.yaml for running on the release cluster. * Create an image_util package to parse image URLs. * Use the Docker image for apps-cd to run create_manifests_pr.py * Add kustomize, go, and some other tools we need * In the docker image create a symbolic link for .ssh so we can pick up ssh credentials created by Tekton.
|
It should be working now. |
|
/assign @richardsliu |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update applications.yaml with a v0.8 release.
The purpose of this PR is to check that just by defining the appropriate
release we can begin building images from release branches and updating
the release branch of kubeflow/manifests
Related to Continuous build of docker images and updating kustomize manifests #450 - Continuous delivery of Kubeflow applications
Create a python script for opening up the PR; this script replaces
the bash script rebuild-manifests.sh that was used previously
The new script doesn't assume that the base branch for PRs is master.
We need this to support updating release branches.
Create a profile in skaffold.yaml for running on the release cluster.
Create an image_util package to parse image URLs.
Use the Docker image for apps-cd to run create_manifests_pr.py
Add kustomize, go, and some other tools we need
In the docker image create a symbolic link for .ssh so we can pick
up ssh credentials created by Tekton.
This change is