Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable travis and do configurations #48

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Enable travis and do configurations #48

merged 2 commits into from
Feb 28, 2018

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Feb 28, 2018 •
edited
Loading

this is cherry-picked from #36 so that it can unblock others.

@jlewi but it seems the CLA status is blocking...

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gaocegege
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jimexist jimexist mentioned this pull request Feb 28, 2018
Merged
Jiayu Liu added 2 commits February 28, 2018 11:57
# This is a combination of 3 commits.
9ee7c99 
# This is the 1st commit message:

adding Python3 support in Dockerfile as well

# The commit message kubeflow#2 will be skipped:

# adding python3-setuptools

# The commit message kubeflow#3 will be skipped:

# also add pip3
adding Python3 support in Dockerfile as well
a6f4e12
@jimexist
Copy link
Member Author

@jlewi seems CLA bot didn't re-check. Can you help manually merge?

@jlewi jlewi merged commit 2a12725 into kubeflow:master Feb 28, 2018
@jimexist jimexist deleted the enable-travis branch February 28, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees

@gaocegege gaocegege

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimexist @googlebot @gaocegege @k8s-ci-robot @jlewi