Fix for #868 #876
Merged
Fix for #868 #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzvara
reviewed
Apr 17, 2020
| func addVolumeMount(pod *corev1.Pod, mount corev1.VolumeMount) *patchOperation { | ||
| i := findContainer(pod) | ||
| if i < 0 { | ||
| glog.Warningf("not able to add VolumeMount %s as Spark container was not found in pod %s", mount.Name, pod.Name) |
There was a problem hiding this comment.
I think others who might depend on podTemplates may find it useful to have the container name said out in the warning-log, which is "executor" for Spark 2 and "spark-kubernetes-executor" for Spark 3. It may help to debug problems of this kind. Verbosity in case of error is always useful. :-)
There was a problem hiding this comment.
We don't parse the sparkVersion due to the lack of validation on the field and a proper parser. This is why in findContainer we match executor container with one of the two possible container names. Because of that, it's no easy way of knowing which container is missing.
akhurana001
pushed a commit
to lyft/spark-on-k8s-operator
that referenced
this pull request
Oct 29, 2020
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #868.