Improve webhook error handling #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyinan926
reviewed
Jun 13, 2019
pkg/webhook/webhook.go
Outdated
| return | ||
| } | ||
| } else { | ||
| denyRequest(w, fmt.Sprintf("Unexpected resource type: %v", review.Request.Resource.String()), http.StatusUnsupportedMediaType) |
There was a problem hiding this comment.
We use lower-case for the first letter of error messages throughout the code base. Better to be consistent.
pkg/webhook/webhook.go
Outdated
| } | ||
|
|
||
| func internalError(w http.ResponseWriter, err error) { | ||
| glog.Errorf("Internal error: %v", err) |
There was a problem hiding this comment.
Ditto. Lower case for the first letter.
|
@liyinan926 updated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdmissionReviewresponsemutatePodsto the client and API server instead of logging/swallowing(FYI, 4xx response codes are still not properly handled by the API server, but that's been fixed recently. They'll continue to return 500 to the client until 1.16.)