Feature: Add pprof endpoint

[ImpSy]

Purpose of this PR

This PR aim to allow access to the pprof server expose by the controller-runtime manager

This could help pinpoint issue with profiling while also opening the way for Profile-guided optimization build of the operator

Proposed changes:

• add --pprof-bind-address option to the controller
• add the associated values to the helm chart

Change Category

Indicate the type of change by marking the applicable boxes:

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

[ChenYi015]

@ImpSy Thanks for the contribution to add the pprof endpoint! Could you sign off your commits by git commit -s -m "commit message"?

[ImpSy]

@ChenYi015 I've done the changed asked and signed my commits, if you want to take a look

[ChenYi015]

@ChenYi015 I've done the changed asked and signed my commits, if you want to take a look

@ImpSy I have left some comments. The e2e test CI failed due to the controller service has empty ports list. Besides, the DCO check fails, so there must be some commits did not get signed off with git commit -s -m "message".

[ChenYi015]

Thanks for the contribution! LGTM, will wait for another approval @yuchaoran2011 @vara-bonthu @jacobsalway .

[jacobsalway]

Thanks for your contribution @ImpSy. I've tested this locally on Kind and it works as intended. I can curl the profiles and analyse them using go tool pprof. I'm sure this will prove useful when we analyse operator performance.

I've left one comment on the flag help string but it's more of a nit. The rest of the PR looks good to me.

[ImpSy]

@jacobsalway The CLI arg description has been changed

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ChenYi015]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobsalway]

@ChenYi015 has already approved the PR and is an approver, so I'm gonna add the label

/lgtm