Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0-rc.0 #2115

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Release Spark operator v2.0.0-rc.0.

Given that this is the first version of Spark Operator after improving the release process #2089, let me elaborate on the details:

  1. Upon merging this PR, a Git tag corresponding to the version specified in the VERSION file (specifically, v2.0.0-rc.0) will be automatically created and pushed, provided it does not already exist.
  2. Following the git tag's push, one workflow detailed in release-docker.yaml will be triggered to publish the Docker image with tag 2.0.0-rc.0(without prefix v).
  3. Concurrently, another workflow detailed in release.yaml will be triggered to create a draft release, with the helm chart packaged as a artifact.
  4. Then, we will edit the release notes and finally publish the release.
  5. Once the release is published, one workflow detailed in release-charts.yaml will be triggered to update the Helm repo index file index.yaml.

Signed-off-by: Yi Chen <github@chenyicn.net>
@ChenYi015
Copy link
Contributor Author

/hold
/assign @yuchaoran2011 @vara-bonthu @andreyvelich

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 9, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vara-bonthu,yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Contributor Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 74b345a into kubeflow:release-2.0 Aug 9, 2024
7 checks passed
@ChenYi015
Copy link
Contributor Author

Hi @andreyvelich. I had met some problems while releasing Spark operator. After this PR was merged, the tag v2.0.0-rc.0 was successfully created and pushed by the workflow. However, another two workflows release-docker.yaml and release.yaml were not triggered by this tag push event as expected. And I cannot figure out why, perhaps you could offer me some guidance.

@andreyvelich
Copy link
Member

Hi @andreyvelich. I had met some problems while releasing Spark operator. After this PR was merged, the tag v2.0.0-rc.0 was successfully created and pushed by the workflow. However, another two workflows release-docker.yaml and release.yaml were not triggered by this tag push event as expected. And I cannot figure out why, perhaps you could offer me some guidance.

@ChenYi015 It looks like according to this one GitHub workflow can't trigger another GitHub workflow: https://github.com/orgs/community/discussions/27028#discussioncomment-3254360

We might need to refactor our test to publish images in the same workflow where we push tag to the GitHub.
WDYT @ChenYi015 ?

@ChenYi015
Copy link
Contributor Author

@andreyvelich Thanks for your help. I agree with you and I will refactor the workflows and put them in one workflow file. For the release of v2.0.0-rc.0 version, since the VERSION file has already been modified, we will delete the tag and push it again manually to trigger the workflows to publish the docker image and draft the release.

jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants