Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stale bot settings #2095

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

andreyvelich
Copy link
Member

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

I updated the stale bot settings which allows us to mark issues and PRs with /lifecycle frozen label that we don't want to close, like here: kubeflow/training-operator#2032 (comment)

Prow bot automatically adds this label to the issues/PRs.

I used the same settings as we use for other projects:

/assign @vara-bonthu @yuchaoran2011 @ChenYi015

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Contributor

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the stale workflow.
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 24, 2024
Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ChenYi015,yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 461ddc9 into kubeflow:master Jul 24, 2024
7 checks passed
@andreyvelich andreyvelich deleted the update-stale-bot branch July 24, 2024 15:42
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 26, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
YanivKunda pushed a commit to YanivKunda/spark-operator that referenced this pull request Aug 5, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants