Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

update pytorch-operator deployment manifests file #295

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

myonlyzzy
Copy link
Contributor

fix issue294

@google-cla
Copy link

google-cla bot commented Aug 4, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link

Hi @myonlyzzy. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@myonlyzzy
Copy link
Contributor Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/assign @johnugeorge @andreyvelich

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myonlyzzy!
Can you sign the CLA, please?
/lgtm

@andreyvelich
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

Please sign Google CLA.

@myonlyzzy
Copy link
Contributor Author

@googlebot I fixed it

@google-cla
Copy link

google-cla bot commented Aug 5, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@myonlyzzy
Copy link
Contributor Author

@googlebot I fixed it

@myonlyzzy
Copy link
Contributor Author

@gaocegege @johnugeorge google cla has been signed.

@andreyvelich
Copy link
Member

/lgtm
/cc @johnugeorge

@Jeffwan
Copy link
Member

Jeffwan commented Oct 20, 2020

/cc @johnugeorge @gaocegege

@gaocegege
Copy link
Member

/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, myonlyzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member

Jeffwan commented Oct 22, 2020

You will need to rebase the master change to make test go through. @myonlyzzy
Can you help do that and then I can approve the change

@aws-kf-ci-bot
Copy link

@myonlyzzy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e e55039f link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit e55039f link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 282cbee into kubeflow:master Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytorch-operator pod CheckCRDExist failed
7 participants