Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Delete v1beta2 code #212

Merged
merged 7 commits into from
Sep 3, 2019
Merged

Delete v1beta2 code #212

merged 7 commits into from
Sep 3, 2019

Conversation

johnugeorge
Copy link
Member

V1beta2 api version is deleted.
Also fixes from following PRs are included.

  1. Adding Controller name to label - Add controller-name label for Pod and service training-operator#1067
  2. Support for custom gang scheduler - feat(pod): Support custom gang scheduler via CLI argument training-operator#1050

@coveralls
Copy link

coveralls commented Sep 2, 2019

Coverage Status

Coverage increased (+0.06%) to 85.345% when pulling 0bed2d4 on johnugeorge:update into f97f7f4 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants