Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Set pytorchjob defaults in test utils #208

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

ohmystack
Copy link
Contributor

When creating a pytorchjob object for testing, the default values should
also be filled in using the same defaulter function in the scheme.

When creating a pytorchjob object for testing, the default values should
also be filled in using the same defaulter function in the scheme.
@k8s-ci-robot
Copy link

Hi @ohmystack. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.281% when pulling ce20c0a on ohmystack:defaults-in-test into de8c866 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/apprve
/ok-to-test
Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0b237bc into kubeflow:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants