Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

PyTorch Operator Prometheus Metrics #175

Merged

Conversation

krishnadurai
Copy link
Contributor

@krishnadurai krishnadurai commented Jun 10, 2019

  • Implements all PyTorch Operator Prometheus Metrics
  • Adds README for documentation

TODOs:

  • Test
  • Correct Documentation

/hold WIP

Implements: #174
Related: #160

cc: @johnugeorge

@k8s-ci-robot
Copy link

Hi @krishnadurai. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jun 10, 2019

Coverage Status

Coverage remained the same at 85.217% when pulling c8a7259 on krishnadurai:feature/prometheus_integration into 6d689cb on kubeflow:master.

@johnugeorge
Copy link
Member

/ok-to-test

@krishnadurai
Copy link
Contributor Author

krishnadurai commented Jun 10, 2019

Ready for review.
@johnugeorge

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8d09ba into kubeflow:master Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants