Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Adding examples for v1 api #164

Merged
merged 2 commits into from
May 21, 2019
Merged

Conversation

johnugeorge
Copy link
Member

Related: #160

@johnugeorge
Copy link
Member Author

/assign @richardsliu

@richardsliu
Copy link
Contributor

@coveralls
Copy link

coveralls commented May 21, 2019

Coverage Status

Coverage remained the same at 85.797% when pulling 7c46a18 on johnugeorge:example-v1 into a5d1017 on kubeflow:master.

@johnugeorge
Copy link
Member Author

@richardsliu done

@richardsliu
Copy link
Contributor

/retest

@johnugeorge
Copy link
Member Author

#165 has to be merged first since v1beta1 support is removed from the ksonnet package.

@richardsliu
Copy link
Contributor

/lgtm

@richardsliu
Copy link
Contributor

/lgtm

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d7aa744 into kubeflow:master May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants