Update developer_guide.md #989
Conversation
As refer site of 'API server' is not accessible, move reference into test doc.
|
Hi @soolaugust. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @soolaugust. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
…st cluster. (kubeflow#989) * Update README.md * Update README.md
* [WIP] Beginning logic for multi-model puller * change version to memory * moving puller to cmd * add downloader and requester logic * add retry logic to donwload * resolve intial comments * resolve comments and rebase * resolve comments * resolve comments and add s3 logic * have downloaded models be under a modelname * resolve comments * add unload logic * added retry logic and further hardening for failures * resolve comments and handle on-start * resolve comments and reorganize * fmt * resolve comments * inline puller * update go mod * move comment * remove unnnecessary comment
* Puller streamlining/simplification Follow-on changes to kubeflow#989 based on remaining review suggestions. - Simplified configmap change diffing - Connect watcher and puller with event channel - Have puller track in-progress ops per model via op completion channel and tie lifecycle of per-model channel+goroutine pairs to this * Minor change: fully decouple puller from watcher * Address some of the review comments The complete ModelOp struct is now passed all the way back and forth.
As refer site of 'API server' is not accessible, move reference into test doc.
This change is