Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction on building viewer CRD controller image #981

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Mar 18, 2019

Instruction on building and pushing viewer CRD controller image is missing.


This change is Reviewable

@neuromage
Copy link
Contributor

Thanks for the fix!

/lgtm

@IronPan or @vicaire please approve, thanks.

@vicaire
Copy link
Contributor

vicaire commented Mar 21, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit d0ba7b2 into kubeflow:master Mar 21, 2019
@terrytangyuan terrytangyuan deleted the patch-1 branch March 21, 2019 03:36
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants