Fix sample test failure because of the type information in the pipelineparam #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument_inputs but the argument_inputs lost the type information
|
/test kubeflow-pipeline-e2e-test |
hongye-sun
reviewed
Mar 15, 2019
|
/lgtm None of the comments has to be fixed in the PR. Please feel free to merge the PR and fix the comments in future PRs. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Will address the PR comments in #975 |
cheyang
pushed a commit
to alibaba/pipelines
that referenced
this pull request
Mar 28, 2019
…neparam (kubeflow#972) * fix bug: op_to_template resolve the raw arguments by mapping to the argument_inputs but the argument_inputs lost the type information * fix type pattern matching * convert orderedDict to dict from the component module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op_to_template resolve the raw arguments by mapping to the argument_inputs but the argument_inputs lost the type information.
Add back the type information when argument_input pipeline_param is created.
Also, adjust the TypeMeta.from_dict_or_str to convert a json string back to TypeMeta
This change is