feat(backend): Implement aws-go-sdk crendentials to support IRSA for s3 in V2 #9502
Conversation
|
@ryansteakley link the previous PRs and issues for background |
|
/assign @chensun |
|
/retest |
| @@ -53,10 +53,10 @@ func OpenBucket(ctx context.Context, k8sClient kubernetes.Interface, namespace s | |||
| if config.Scheme == "minio://" { | |||
| cred, err := getMinioCredential(ctx, k8sClient, namespace) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("Failed to get minio credential: %w", err) | |||
| return nil, fmt.Errorf("Failed to get minio credential: %w", err) | |||
There was a problem hiding this comment.
nit: remove trailing whitespace
|
@chensun have fixed the whitespace |
|
@ryansteakley: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } | ||
|
|
||
| func getAWSCredential() (cred *credentials.Credentials, err error) { | ||
| return credentials.NewCredentials(&credentials.ChainProvider{}), nil |
There was a problem hiding this comment.
@ryansteakley are you sure that you did not forget to specify the providers in the ChainProvider?
Because by default a chain provider has no internal providers and will always error.
|
@ryansteakley @chensun I am pretty sure this code will never get called, because any s3 bucket path would start with However, is is possible that IRSA was working before this PR if |
Description of your changes:
Use the aws-go-sdk credentials.ChainProvider to support IRSA in kfp v2. This functionality is already supported in V1, this pr aims to keep parity with v1 as IRSA is supported in v1 backend
pipelines/backend/src/apiserver/client/minio.go
Line 30 in f167e15
Checklist: