Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create experiment only if it's not exist. #892

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 1, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 1, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 1, 2019

/lgtm

@@ -108,7 +108,7 @@ def create_experiment(self, name):
"""
import kfp_experiment

experiment = self.get_experiment(experiment_name=name)
experiment = self.get_experiment(experiment_name=name, ignore_error=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, the pythonic way to accomplish this is to just use try/except.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 2, 2019

/lgtm

@hongye-sun
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@hongye-sun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@hongye-sun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f9cea6d into kubeflow:master Mar 2, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
* Create experiment only if it's not exist.

* Skip error if experiment is not found.

* Use try catch to bypass the not found error.
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Migrate tf-operator to new test-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants