Add bigquery docstring and dump output path. #885
Conversation
| if output_gcs_path: | ||
| job_id = 'extract_' + ctx.context_id() | ||
| extract_job = _get_job(client, job_id) | ||
| if not extract_job: | ||
| extract_job = client.extract_table(table_ref, output_gcs_path) | ||
| extract_job.result() # Wait for export to finish | ||
| extract_job.result() # Wait for export to |
There was a problem hiding this comment.
comment: wait for export to 'finish'?
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add bigquery docstring and dump output path. * Auto create dataset if it's not exist and dump results in local files * make dataset location configurable * Add todo to make kfp output path configurable. * Fix comment
Fix a typo made by previous PR
This change is