SDK - Passing the environment variables to container op #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the DSL bridge code was written, ContainerOp did not support env, so we did not pass it. Now we're adding the passing code. Added test that chacks that the env variables get to the ContainerOp.
Ark-kun
force-pushed
the
Passing-the-environment-variables-to-ContainerOp
branch
from
faebaf7 to
24afc57
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongye-sun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
changed the title
cheyang
pushed a commit
to alibaba/pipelines
that referenced
this pull request
Mar 28, 2019
When the DSL bridge code was written, ContainerOp did not support env, so we did not pass it. Now we're adding the passing code. Added test that chacks that the env variables get to the ContainerOp.
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
Migrate katib repo to new test-infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the environment variables to ContainerOp
When the DSL bridge code was written, ContainerOp did not support env, so we did not pass it. Now we're adding the passing code.
Added test that chacks that the env variables get to the ContainerOp.
The code is committed on top of #712 and #713, so see the last commit only: faebaf7
This change is