Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release new components: deployer #849

Merged
merged 4 commits into from
Feb 27, 2019
Merged

release new components: deployer #849

merged 4 commits into from
Feb 27, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Feb 22, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777 gaoning777 requested a review from jinchihe February 22, 2019 19:34
@gaoning777 gaoning777 mentioned this pull request Feb 22, 2019
Closed
@gaoning777
Copy link
Contributor Author

I will verify the sample test results before removing the do-not-merge label.

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@rileyjbauer rileyjbauer mentioned this pull request Feb 22, 2019
Closed
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

jinchihe
jinchihe reviewed Feb 22, 2019
View reviewed changes
Copy link
Member

@jinchihe jinchihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 23, 2019
@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@jinchihe
Copy link
Member

/lgtm

@gaoning777
Copy link
Contributor Author

wait for the tfdv break fix in #856

@gaoning777
Copy link
Contributor Author

Another fix for the tfma license: #857

@gaoning777
Copy link
Contributor Author

gaoning777 commented Feb 26, 2019 •
edited
Loading

GCP component fix: #860 and #861

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@rileyjbauer
Copy link
Contributor

Thanks a lot Ning!

/lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777 gaoning777 merged commit 9511d96 into kubeflow:master Feb 27, 2019
@gaoning777 gaoning777 deleted the release-component-for-deployer branch February 27, 2019 00:40
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@gaoning777
release new components: deployer (kubeflow#849)
d1c8b2a 
release new component images
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Update onboarding doc (kubeflow#849)
df23d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchihe jinchihe jinchihe left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@rileyjbauer rileyjbauer Awaiting requested review from rileyjbauer

Assignees

@jinchihe jinchihe

@rileyjbauer rileyjbauer

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @jinchihe @rileyjbauer @k8s-ci-robot