Update graph styling #829
Update graph styling #829
Conversation
|
/test kubeflow-pipeline-e2e-test |
edges. Previously diagonal edges are converted into two vertical edges and one horiztonal
… does selecting a node More fixes, stop stacking starting edges
rileyjbauer
force-pushed
the
update-graph-style
branch
from
c46b764 to
d88297e
Compare
rileyjbauer
force-pushed
the
update-graph-style
branch
from
5a19b28 to
c5adb6d
Compare
rileyjbauer
force-pushed
the
update-graph-style
branch
from
c5adb6d to
fb9ecf3
Compare
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rileyjbauer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Updates styling for the graphs * Break all diagonal edges into vertical and horizontal components * Checkpointing. A lot of minor adjustments being made * Change graph rendering to only use horizontal and vertical lines for edges. Previously diagonal edges are converted into two vertical edges and one horiztonal * Small cleanup * Hovering over node now highlights all incoming and outgoing edges, as does selecting a node More fixes, stop stacking starting edges * Clean up * Remove edge starting circle code * Returns the DAG to using arbitrary angles rather than right angles * Adds small vertical segment to end of all edges * Significant clean up and updating tests * A little more clean up and adding tests for the new Status util function * One more test for Status * Increase node font weight * PR comments * A little more cleanup in Graph
* test(kfp): Move kfp test infra to kfp-ci project * fix * switch project
* Add kfdef type on issue template * Add KFServing debugging guide * Fix docs * Add request flow debugging * Add debug commands * Add performance debugging * Add tracing image * Add link to main README * Istio ingress probe fix instruction * Apply suggestions from code review Co-authored-by: Animesh Singh <singhan@us.ibm.com> * Address review comments Co-authored-by: Animesh Singh <singhan@us.ibm.com>
…eflow#829) * cos-logger as a separate module. * temp * temporary hack: using scrapcodes as repository. * correction of import in README.md * found a golang trick to use local packages. * naming changes * renaming update to README.md
These changes affect both the static and runtime graphs.
In addition to the styling changes, the graphs now highlight inbound and outbound edges from nodes when the user hovers over them.
Old styling:
New styling (with a node selected):
This change is