Fixed validation in new run form when filling name then pipeline #826
Conversation
|
Hi @elviraux. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @elviraux. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for fixing this! |
|
/retest |
* add generic URI for Storage (kubeflow#826) * handle query parameters * add http as available storage type * update the README * cleanup README * add unit tests * use urlparse to get file name * fail loudly when no filename in uri * inclue http(s) in SupportedStorageURIPrefixList * use regex to check http(s) uri in storage * fix storageURI validation * go fmt * draft for zip & tar archives * fix imports * update tests * support for gzip * draft version of URI examples * newline changes * unit test for http(s) storageUri validation * use mimetypes.guess_type to derive MIME type from url * fix Content-Type validations in storage initializer * update sample README for new ingress access instructions
Closes #612
Now :
This change is