Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a local volume sample for the Viewer CRD #822

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Feb 13, 2019

Also edited the README for viewer CRD usage


This change is Reviewable

@swiftdiaries
Copy link
Member Author

/assign @neuromage

@neuromage
Copy link
Contributor

/lgtm

Thanks @swiftdiaries! Looks good to me.
@vicaire or @IronPan can you please approve? Thanks.

@vicaire
Copy link
Contributor

vicaire commented Feb 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit 304f574 into kubeflow:master Feb 15, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ow#822)

* Add an easier method to obtain Dex session token

* Add an easier method to obtain Dex session token

* Add an easier method to obtain Dex session token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants