Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert dataflow component version in samples to unblock release #817

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Revert dataflow component version in samples to unblock release #817

merged 1 commit into from
Feb 15, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Feb 12, 2019 •
edited by jlewi
Loading

This change is Reviewable

@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

1 similar comment
@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

1 similar comment
@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-sample-test

@hongye-sun hongye-sun changed the title [WIP] check sample test status Revert dataflow component version in samples to unblock release Feb 14, 2019
@hongye-sun
Copy link
Contributor Author

/hold

Will unhold after sample test pass

@hongye-sun
Copy link
Contributor Author

/hold cancel

@hongye-sun
Copy link
Contributor Author

The sample test is passed now.

@hongye-sun hongye-sun mentioned this pull request Feb 15, 2019
Merged
@vicaire
Copy link
Contributor

vicaire commented Feb 15, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun hongye-sun merged commit 6db78ca into kubeflow:master Feb 15, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@Jeffwan
Add reusable scripts to kubeflow/testing (kubeflow#817)
67853ff 
* Add resuable scripts to kubeflow/testing

* Remove github_changelog_generator

This scripts will encounter rate limit issue in large repo. We should find better ways to generate changlog
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@andyi2it
Fix downloading model with nested sub folders from gcs kubeflow#817 (k…
7962f1c 
…ubeflow#2152)

* Fixes kubeflow#817

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@vicaire vicaire

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongye-sun @vicaire @k8s-ci-robot