Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more samples for the ScheduledWorkflow CRD. #8

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Jun 6, 2018

This PR contains a couple changes:

  • It adds more samples in the example directory.
  • It provides instructions to run a ScheduledWorkflow in README.md.
  • It renames pipeline-crd.yaml to scheduledworkflow-crd.yaml

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from jlewi June 6, 2018 01:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vicaire

Assign the PR to them by writing /assign @vicaire in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire merged commit 78dcb7f into master Jun 6, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Added KFService types

* Added Canary as a top level spec and fixed a few optional fields
HumairAK referenced this pull request in HumairAK/data-science-pipelines Jan 22, 2024
UPSTREAM: <carry>: remove unused images for v2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants