Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications done by the execution of the release script. #777

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

vicaire
Copy link
Contributor

@vicaire vicaire commented Feb 4, 2019

@IronPan
Copy link
Member

IronPan commented Feb 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paveldournov
Copy link
Contributor

Thanks Pascal!

@vicaire
Copy link
Contributor Author

vicaire commented Feb 5, 2019

/test kubeflow-pipeline-e2e-test

3 similar comments
@vicaire
Copy link
Contributor Author

vicaire commented Feb 5, 2019

/test kubeflow-pipeline-e2e-test

@vicaire
Copy link
Contributor Author

vicaire commented Feb 5, 2019

/test kubeflow-pipeline-e2e-test

@vicaire
Copy link
Contributor Author

vicaire commented Feb 6, 2019

/test kubeflow-pipeline-e2e-test

@vicaire vicaire changed the title Modificaitons done by the execution of the release script. Modifications done by the execution of the release script. Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

@vicaire: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 9b40778 link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vicaire
Copy link
Contributor Author

vicaire commented Feb 6, 2019

Looks like the issue is that the cluster deletion takes too long. Otherwise the e2e tests are succeeding.

I am going to merge this PR to unblock the release. Asked @IronPan to double check and got approval.

@vicaire vicaire merged commit be58c08 into kubeflow:master Feb 6, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* doc: cleanup_ci.py instructions

* chore: cleanup_ci.py run instructions

* fix cleanup_ci.py

* fix linting

* include cleanup kubeflow ci as a cronjob

* fix readme
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* fix-775

* add metadata directly

* fix metadata tyep error
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants