Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component_sdk tests to travis tests #752

Closed
wants to merge 0 commits into from
Closed

Add component_sdk tests to travis tests #752

wants to merge 0 commits into from

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jan 30, 2019 •
edited by jlewi
Loading

The test uses tox to run against python 2.7 and 3.6 version.

This change is Reviewable

gaoning777
gaoning777 approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@hongye-sun
Copy link
Contributor Author

@IronPan and @vicaire, I need your owner approval for this travis config change. Thanks.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@hongye-sun hongye-sun closed this Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun hongye-sun mentioned this pull request Feb 1, 2019
Merged
@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 1, 2019

/reopen

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: Failed to re-open PR: state cannot be changed. There is already an open pull request from hongye-sun:sdk to kubeflow:master.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@Ark-kun: Failed to re-open PR: state cannot be changed. There is already an open pull request from hongye-sun:sdk to kubeflow:master.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@animeshsingh
fix typo (kubeflow#752)
b40faa4
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Update install readme with KF 1.4.0 deployment (kubeflow#752)
e246883 
* Update install readme with KF 1.4.0 deployment

* Update kfp_tekton_install.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@gaoning777 gaoning777

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @k8s-ci-robot @Ark-kun @gaoning777