Refactor UI buttons to lib file #737
Conversation
| title: 'Delete', | ||
| tooltip: 'Delete', | ||
| }], | ||
| title: `Delete ${this.state.selectedIds.length} pipeline${s(this.state.selectedIds)}?`, |
There was a problem hiding this comment.
is the end of this line still correct?
There was a problem hiding this comment.
You mean the use of the s function rather than doing the check? It should be correct, yes.
There was a problem hiding this comment.
oh! I had no idea we had a function for that in utils!
There was a problem hiding this comment.
It sneaked in a while ago, feel free to let me know your feelings on the name. :)
|
/lgtm |
|
prow was temporarily down. re lgtm should work now |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer, yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To keep things consistent and reduce duplication. No functional changes.
This change is