Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dataproc cluster version #735

Merged
merged 1 commit into from
Jan 26, 2019
Merged

fix dataproc cluster version #735

merged 1 commit into from
Jan 26, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Jan 25, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777 gaoning777 mentioned this pull request Jan 25, 2019
Closed
@gaoning777 gaoning777 requested a review from IronPan January 25, 2019 22:56
@IronPan
Copy link
Member

IronPan commented Jan 25, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 97645e7 into kubeflow:master Jan 26, 2019
vswami78
vswami78 reviewed Apr 2, 2019
View reviewed changes
Copy link

@vswami78 vswami78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaoning777 can imageVersion not be specified - this way the latest and greatest version could automatically applied to the create cluster. If it has to be specified - can this be turned into a parameter instead of hard-coding it ?

@gaoning777
Copy link
Contributor Author

gaoning777 commented Apr 2, 2019 •
edited
Loading

The version was fixed to avoid a compatibility bug that showed up.
We recently published some out-of-box components and dataproc create cluster is one of them, which provides very flexible configurations.
Could you try this out: https://github.com/kubeflow/pipelines/tree/master/components/gcp/dataproc/create_cluster?
Thanks

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Change type for GRPC string parameter to 'string' (kubeflow#735)
7ce57d7 
In parameters a string value should be an actual string, not a
collection of arbitrary bytes. So change the GRPC type from "bytes" ->
"string".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vswami78 vswami78 vswami78 left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@qimingj qimingj Awaiting requested review from qimingj

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@IronPan IronPan

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @IronPan @k8s-ci-robot @vswami78