SDK/Components/Python - Improved Python2 compatibility #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved Python2 compatibility in Lightweight python components
|
/lgtm |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test kubeflow-pipeline-build-image |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-build-image |
Ark-kun
deleted the
SDK/Components/Python---Improved-Python2-compatibility
branch
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Fix the docker image; I switched the base image to alpine but
didn't update the pkg commands from apt to apk.
* Refactor the code to make it easier to write a unittest for the error
regexes.
* Use a global map for the regexes
* Use named constants for the particular error types
* We should be using CombinedOutput in order to get stdout and stderr
when shelling out.
* Mark required flags
* Use working directory as default directory
* Change flag name for push to refspec
* Add an option to format logs as json
* This is needed when running in cluster and using stackdriver so
that multi line entries and metadata fields like level and filename
are recorded as structured entries.
* Add kustomize to the prctl image
* This is a quick fix so we can use the prctl image to run hydration
of manifests
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…ry (kubeflow#718) * Fix check_sa_exists not checking all service accounts * Fixed lint errors
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…eflow#718) * update KFP SDK version to 1.7.2, create KFP-TEKTON 1.0.0 release * update standalone deployment readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @qimingj @gaoning777 @hongye-sun
This change is